Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-16633 Rebranded embedded #14544

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Dec 6, 2024

Done

  • Rebranded ubuntu.com/embedded

QA

Issue / Card

Fixes #16633

@webteam-app
Copy link

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (218fb03) to head (653a0cc).
Report is 23 commits behind head on feature-rebrand-iot.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature-rebrand-iot   #14544   +/-   ##
====================================================
  Coverage                69.64%   69.64%           
====================================================
  Files                      120      120           
  Lines                     3419     3419           
  Branches                  1174     1174           
====================================================
  Hits                      2381     2381           
  Misses                    1013     1013           
  Partials                    25       25           

@eliman11
Copy link

eliman11 commented Dec 6, 2024

Thanks @muhammad-ali-pk! Looks great, a couple quick comments:

  • Change to US spelling: 'unauthorized' under 'Scanning'
  • Could we link 'Contact us' here to open the modal?
Screenshot 2024-12-06 at 11 44 45
  • Sorry for the confusion! The HTML tags on this page are a little trickier, I've annotated on Figma what the right ones should be

@muhammad-ali-pk
Copy link
Contributor Author

Thanks @eliman11 ! All done!

@eliman11
Copy link

Looks good, thanks @muhammad-ali-pk!

@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 10, 2024

thanks @muhammad-ali-pk !

for this section:
Screenshot 2024-12-10 at 09 48 46

  • could you wrap the image in a shallow pls? it looks off to me where the spacing isn't even – and if this doesn't look great either, I'll probably ask if you can remove the shallows from both :')

For this section:
Screenshot 2024-12-10 at 09 50 37

  • since there's no link for the second item, could you allow for breaks of the hr between each of the items (and remove from docker entirely)

all else is good!

@muhammad-ali-pk muhammad-ali-pk merged commit 0553f20 into canonical:feature-rebrand-iot Dec 12, 2024
15 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the iot-embedded-rebrand branch December 12, 2024 12:05
muhammad-ali-pk added a commit that referenced this pull request Dec 13, 2024
* Apply page redesign

* Apply design suggestions

* Apply design fixes

* Bump vanilla version and switch to quote macros

* Apply code review

* Apply page redesign

* Apply design review

* Update asset

* Fix blog IoT blog variables

* Rebrand /iot/smart-displays

* rebrand /internet-of-things/gateways

* review changes

* Apply code review

* review changes

* WD-16635 Redesigned internet-of-things/management (#14529)

* Redesigned internet-of-things/management

* Applied design review

* Fix missing hr's on smaller screens (using vanilla patterns)

* Applied UX Review

* Use image module

* Fix line breaks + use hr for p-rule

* Removed unnecessary outer_content block

* Fixed line break

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-17582 Redirect to success notification instead of thank-you page. (#14545)

* Fix: not redirected to static contact-us page when javascript is disabled

* Redirect to success banner upon form submission

---------

Co-authored-by: Muhammad Ali <[email protected]>

* Adress visual design comments

* Address UX comments

* Use modal form on iot/management (#14548)

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16645 Redesigned internet-of-things/smart-city (#14534)

* Redesigned internet-of-things/smart-city

* Accessible headings order

* Reduced padding for image with h5

* Applied UX Review

* Structural hierarchy cleanup

* Use image module

* Applied design review

* Applied code review

---------

Co-authored-by: Muhammad Ali <[email protected]>

* review design changes

* Address design comments

* WD-16647 Redesigned internet-of-things/smart-home (#14530)

* Redesigned iot/smart-home

* Applied design review

* Applied UX Review

* Applied code review

* Applied code review suggestions

---------

Co-authored-by: Muhammad Ali <[email protected]>

* Update logos

* copydoc update

* Apply code review suggestions

* WD-16633 Rebranded embedded (#14544)

* Rebranded embedded page

* Quick fix: remove empty tag

* Applied UX Review

* Applied design review suggestions

* Added aria-labels on Learn more.* links

* Lazy load images not currently in viewport

* Added a shallow section around image (design suggestion)

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-17646 Removed pagination from modal form and converted to single page (#14555)

* Removed pagination from modal form and converted to single page

* Applied design review suggestion

---------

Co-authored-by: Muhammad Ali <[email protected]>

* fix: appstore contact-form not opening in popup

* WD-17753 Iot embedded modal form - removed pagination + conversion to single page (#14567)

* Removed pagination + conversion to single page

* Cleanup

---------

Co-authored-by: Muhammad Ali <[email protected]>

* Updated new thank-you banner

* format gateways.html

* Removed pagination + refactor (#14570)

Co-authored-by: Muhammad Ali <[email protected]>

* Removed pagination + refactor (#14571)

Co-authored-by: Muhammad Ali <[email protected]>

---------

Co-authored-by: Britney Wang <[email protected]>
Co-authored-by: immortalcodes <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
Co-authored-by: Akbar Abdrakhmanov <[email protected]>
Co-authored-by: Britney Wang <[email protected]>
Co-authored-by: Madhur Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants