-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wd 17296 dev create solutions open source security cyber resilience act #14560
base: main
Are you sure you want to change the base?
Wd 17296 dev create solutions open source security cyber resilience act #14560
Conversation
@mattea-turic Can you review the page once? There is a demo at https://ubuntu-com-14560.demos.haus/solutions/open-source-security/cyber-resilience-act The forms are not done yet |
ac449b0
to
10b6c83
Compare
Thanks @abhigyanghosh30 ! A few comments from me:
For the hero section:
For "What is the Cyber Resilience Act (CRA)":
For "What products and devices does the CRA regulate?":
For "The Cyber Resilience Act requirements in a nutshell":
For the section, "Who does the Cyber Resilience Act apply to?":
For "Canonical’s commitment to the CRA":
For the CTA section ("Need help with your CRA roadmap..."):
For "How the Cyber Resilience Act will impact device manufacturers":
For "Fast-track compliance with Ubuntu Pro for Devices":
For the FAQ section:
For "Dive deep into the CRA with our free resources":
|
|
2d4e075
to
676c0e4
Compare
@mattea-turic @Sophie-32 I addressed most of your concerns. Please check again if I have addressed everything.
I did not exactly understand what this meant so I just reduced the size of the section. |
@abhigyanghosh30 Just tried checking, but the link doesn't seem to be working |
@mattea-turic the demo was bugging out. Fixed it |
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once the duplication is removed. Thank you for the great work!
…index.html Co-authored-by: Fasih Mehmood <[email protected]>
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
</p> | ||
</div> | ||
<div class="p-cta-block"> | ||
<a href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a fallback URL in case user doesn't have JS enabled. I see that it is not included in the copy doc. Could you please check with Gloria or UX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave the fallback for now because the site needs to be up before the holidays
</div> | ||
</div> | ||
<div class="p-section--shallow"> | ||
{{ image ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here can you format the image template please
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
templates/solutions/open-source-security/cyber-resilience-act/index.html
Show resolved
Hide resolved
<div class="u-fixed-width p-strip"> | ||
<section class="p-strip"> | ||
<h2> | ||
<a aria-controls="contact-modal" class="js-invoke-modal">Need help with your CRA roadmap? Contact our experts ›</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a fallback href
for the anchor tag here
templates/solutions/open-source-security/cyber-resilience-act/index.html
Outdated
Show resolved
Hide resolved
<h1 class="u-no-margin--bottom">Meet your Cyber Resilience Act requirements with Canonical</h1> | ||
</div> | ||
<div class="col"> | ||
<div class="p-section--shallow u-hide--large"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this empty div be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Needed for spacing
|
||
{% block content %} | ||
|
||
<section class="p-section--hero"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using hero patterns from Vanilla for hero sections, can you update it to use the pattern? Link to the doc here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesnot follow exactly any of the hero patterns as all of them require an image but this hero doesnot have an image
Done
QA
./run serve
ordotrun
Issue / Card
Fixes #WD-17296
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines