chore(/gcp): Update content #14562
Merged
chore(/gcp): Update content #14562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
There was a problem hiding this comment.
@petesfrench Looks good. I mentioned you under some comments in the copy doc, could you implement those as well please? Thanks!
|
@fasih-mehmood It seems my find and replace was not greedy enough in this case. I have updated accordingly |
Thank you! |
There was a problem hiding this comment.
@petesfrench It looks like the changes were reverted back to use optimise instead of optimize
petesfrench
force-pushed
the
wd-17456
branch
from
59b63df to
a514ca6
Compare
petesfrench
force-pushed
the
wd-17456
branch
from
a514ca6 to
23ddde3
Compare
|
@fasih-mehmood Apologies, not sure why my changes aren't being picked up |
fasih-mehmood
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
fasih-mehmood
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-17456