-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-14930 Dev create /partner/intel #14568
base: main
Are you sure you want to change the base?
WD-14930 Dev create /partner/intel #14568
Conversation
Thanks @immortalcodes ! :) A few comments: For the Hero section:
For the "Explore how to optimize performance for Intel platforms in our blog" section:
For the "Explore Ubuntu-certified Intel Hardware backed by Ubuntu Pro" section:
For the "Want to optimize your silicon for Ubuntu?" section:
|
Hey, regarding the sizing on smaller screens, is it related to alignment being a bit off? This is the default property of Vanilla and there is less that could be done for this, we could remove the vanilla class but that will make images bigger like in ss below or we can decide not to have images at all. |
I think this might be the best option; if they're too big they'll distract from the text and force more scrolling I'll +1! (once new demo is up) |
Thanks @immortalcodes! A side note on the navigation for this page - I'll put in a separate request to edit the silicon partners page to to include links to relevant webpages and to add a menu for 'Partners' in the footer. Comments:
|
Thanks for your patience on this page @immortalcodes! I just checked with Gloria - the URL for this page should be canonical.com/partners/silicon/intel instead of ubuntu.com/partner/intel suggested on the copydoc. Would it be possible to make this change? The stakeholder has also requested that we redirect ubuntu.com/download/intel and ubuntu.com/intel to this new page. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the stakeholders changed the page location from u.com to c.com, if that's the case then this page shouldn't live on u.com at all but only add redirects. Can we move this PR over to c.com?
@@ -674,7 +674,6 @@ packages/kde351.*/?: "https://releases.ubuntu.com/" | |||
partners/contact-us/?: "https://partner-portal.canonical.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add redirects from /download/intel
and /intel
to the new page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, just one more thing. I'll leave a +1 with changes
templates/partner/intel.html
Outdated
</section> | ||
|
||
<section class="p-section"> | ||
<div class="row--50-50"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This row should be wrapped in a shallow section
You can UX+1 with those changes. |
Done
QA
./run serve
ordotrun
Issue / Card
Fixes # WD-14930
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines