Classifier Callback

[ghost]

This issue is to implement the functionality requested in capstone-coal/capstone-coal.github.io#32 to allow the user to control the classification algorithm. One option is to refactor the mineral classification method to take a callback which defaults to the current SAM implementation. Additional work remains to figure out the best way to do this.

[thomkenn]

This could be interesting, ill take a look at it

[lewismc]

@thomkenn please begin thinking about implementing this. I already have other work lined up to expand the Classification algorithms for pycoal which would leverage this functionality.
Any question, please post them here.

[thomkenn]

Am currently testing code on my local machine, will submit a pull request when i have it working.

[lewismc]

Hi @thomkenn you've been cranking on this now since your original interest on January 18th, 2018. Do you have a pull request?

[thomkenn]

ok i sent in a pull request with the tentative formatting i had in mind for this to work. Further documentation study and changing references to the mineral.py throughout the greater program will be required and updated after this is completed

[lewismc]

See my comment on the PR, close the PR and make sure your PR only includes proposed changes not en entire history of the project. Thanks

[thomkenn]

Apologies, i had github improperly configured, i went off the notes you gave on my last PR and i believe i have submitted the proper form

[lewismc]

@EvandroCT can you please start working on this issue to get yourself familiarized with the project source code? Thank you

[EvandroCT]

Hey folks, please, take a look at my PR #155

[lewismc]

Thank you @EvandroCT