Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content before Sticky component inside StickyContainer ignored #247

Open
1 of 3 tasks
shunxing opened this issue Jun 27, 2018 · 5 comments
Open
1 of 3 tasks

Content before Sticky component inside StickyContainer ignored #247

shunxing opened this issue Jun 27, 2018 · 5 comments
Labels

Comments

@shunxing
Copy link

shunxing commented Jun 27, 2018

Hi guys

I'm submitting a ...

  • bug report
  • feature request
  • support request

If you're reporting a bug, please provide a minimal demonstration of the problem

https://codesandbox.io/s/xvnxy4lmjq

What is the current behavior?

The red div becomes sticky too early.

What is the expected or desired behavior?

The red div should become sticky only when we scroll to its top

What is your environment?

  • Version: macOS High Sierra
  • Browser: Chrome 67
@shunxing shunxing changed the title Content before Sticky component inside StickyContainer not caught Content before Sticky component inside StickyContainer ignored Jun 27, 2018
@vcarl
Copy link
Contributor

vcarl commented Jun 27, 2018

Hi @shunxing can you please follow the issue template? It asks for a lot of information that I can't really help you without.

@shunxing
Copy link
Author

@vcarl Hi ! done !

@vcarl
Copy link
Contributor

vcarl commented Jun 28, 2018

Thank you! I'll try to take a peek soon, but I'm very busy with work and life things.

@vcarl vcarl added bug and removed user support labels Jun 29, 2018
@vcarl
Copy link
Contributor

vcarl commented Jun 29, 2018

TY for the excellent bug report! I'm flying today, I'll try to poke this while I'm in the air.

@vcarl
Copy link
Contributor

vcarl commented Jul 16, 2018

I should probably capture some of my findings. I did spend a bit of time on this, but this is the first time I've debugged the core of the logic for the library. This seems like a pretty strong assumption of the library, it's going to take a good bit longer before I can find something that I'm positive won't break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants