Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logging to be clearer #879

Open
keevan opened this issue Mar 20, 2024 · 0 comments
Open

Retry logging to be clearer #879

keevan opened this issue Mar 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@keevan
Copy link
Contributor

keevan commented Mar 20, 2024

Currently it will always log the same message if it attempts to schedule a retry, even if the retry ends up being the normal time the dataflow runs.

But if there is no retry scheduled, it will set the next run to the normal
scheduled time. But the prior run will still print "Cron: Rescheduling dataflow
to retry", which is a bit misleading.

A suggestion would be to log the counter as well, for example, we would end up with the following cases.
Let's assume the step name is "Cron", the retry logic is set to 2 and

  • Main run: "Cron: Retrying run at 2024-04-21 09:00:00"
  • First retry: "Cron: Retry 1 of 2 done. Retrying run at 2024-04-21 09:00:00"
  • Second and last retry: "Cron: Retry 2 of 2 done. No longer retrying."

$this->log("Rescheduling dataflow to retry.");

This will likely require updating the logic for the scheduler method, to clarify behaviour in the logs.

@keevan keevan added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant