Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config_changed log for cachecheck #165

Open
matthewhilton opened this issue Nov 16, 2023 · 2 comments
Open

Add config_changed log for cachecheck #165

matthewhilton opened this issue Nov 16, 2023 · 2 comments

Comments

@matthewhilton
Copy link
Contributor

Whenever the cachecheck re-pings, it should log a config change

This is so we can see the history of what updated the value and at what time

@brendanheywood
Copy link
Contributor

When it is updating it has only seen the cached version, so lets also read from the db when it is about to update. This does two things:

  1. it tells us if the db was already out of sync
  2. it removes any possible read replica uncertainty

@brendanheywood
Copy link
Contributor

Also not sure about config_log, maybe just error_log is enough. This will spam the config log daily

matthewhilton added a commit that referenced this issue Nov 17, 2023
matthewhilton added a commit that referenced this issue Nov 17, 2023
matthewhilton added a commit that referenced this issue Nov 17, 2023
matthewhilton added a commit that referenced this issue Nov 19, 2023
matthewhilton added a commit that referenced this issue Nov 19, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Nov 20, 2023
brendanheywood pushed a commit that referenced this issue Nov 20, 2023
matthewhilton added a commit that referenced this issue Jan 22, 2024
brendanheywood pushed a commit that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants