Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: interface-specific requirements.txt files are vestigial and confusing #1169

Open
2 tasks done
pauladkisson opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1171
Open
2 tasks done

[Bug]: interface-specific requirements.txt files are vestigial and confusing #1169

pauladkisson opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1171
Labels
bug

Comments

@pauladkisson
Copy link
Member

What happened?

After the switch to pyproject.toml for modality dependencies (#1118), the interface-specific requirements.txt files don't do anything and should be removed.

Steps to Reproduce

...

Traceback

No response

Operating System

macOS

Python Executable

Conda

Python Version

3.12

Package Versions

No response

Code of Conduct
@h-mayorquin
Copy link
Collaborator

They should. I was leaving them a bit longer in case we had to revert but I guess they we could be recovered from the git repo history if we were to needed which is unlikely now.

Let's remove them. Thanks for opening and issue.

@pauladkisson pauladkisson linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed requirements.txt files from all datainterfaces catalystneuro/neuroconv
2 participants
@h-mayorquin @pauladkisson