Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong factorial for negative numbers #1

Open
PradyumnaKrishna opened this issue Feb 1, 2023 · 0 comments
Open

Wrong factorial for negative numbers #1

PradyumnaKrishna opened this issue Feb 1, 2023 · 0 comments

Comments

@PradyumnaKrishna
Copy link
Member

Issue
In factorial.cpp, the factorial calculated for negative number is wrong. Here is the output:

Enter a positive integer: -5
Factorial of -5 = 1

Expected Outcome
Factorial should be calculated for only positive number and exist for negative inputs.

Possible Fixes
Adding if-else condition may fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants