Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup dependabot to update dependencies for Rust DRT code #491

Open
2 tasks
john-h-kastner-aws opened this issue Dec 11, 2024 · 2 comments · Fixed by #499
Open
2 tasks

Setup dependabot to update dependencies for Rust DRT code #491

john-h-kastner-aws opened this issue Dec 11, 2024 · 2 comments · Fixed by #499
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@john-h-kastner-aws
Copy link
Contributor

Category

Other

Describe the feature you'd like to request

We use dependabot for our library in cedar-policy/cedar, but there are also rust packages here which we should ideally keep up to date. We should probably start committing Cargo.lock files and having dependabot update them for the same reasons we did in this in main repo.

Describe alternatives you've considered

.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@john-h-kastner-aws john-h-kastner-aws added the internal-improvement Refactoring, performance improvement, or other non-breaking change label Dec 11, 2024
@john-h-kastner-aws john-h-kastner-aws changed the title Setup dependabot to update rust dependencies for Rust DRT code Setup dependabot to update dependencies for Rust DRT code Dec 11, 2024
@john-h-kastner-aws
Copy link
Contributor Author

PR did not quite work:

Dependabot couldn't fetch all your path-based dependencies

The affected dependencies were ../cedar/cedar-policy/Cargo.toml, ../cedar/cedar-policy-core/Cargo.toml, ../cedar/cedar-policy-validator/Cargo.toml, ../cedar/cedar-policy-formatter/Cargo.toml and ../cedar/cedar-testing/Cargo.toml.

To use path-based dependencies with Dependabot the paths must be relative, resolve to a directory in this project's source code, and contain a valid Rust project.
[Troubleshoot Dependabot errors](https://docs.github.com/github/managing-security-vulnerabilities/troubleshooting-dependabot-errors)

@john-h-kastner-aws
Copy link
Contributor Author

Tried to fix with #502, but it didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant