-
Notifications
You must be signed in to change notification settings - Fork 82
/
panic_safety.sh
executable file
·67 lines (60 loc) · 2.5 KB
/
panic_safety.sh
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
#!/bin/bash
# Copyright Cedar Contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# This script ensures that exceptions to the clippy lints have explanations in
# the comments. It assumes that clippy is properly configured to forbid the
# lints listed in `panic_markers` and that clippy is being run regularly.
# Clippy is automatically run against PRs on GitHub. Clippy lints are
# controlled for all of our crates by `./.cargo/config.toml`.
# Check that panics are prefixed with a line that has "PANIC SAFETY" in it
total_panics=0
failed=0
crates=($(cargo metadata --no-deps --format-version 1 | jq -r '.packages | map(.name) | join(" ")'))
panic_markers=("unwrap_used expect_used fallible_impl_from unreachable indexing_slicing panic")
for crate in ${crates[@]}; do
crate_panics=0
for panic_marker in ${panic_markers[@]}; do
while read -r filename linenum ; do
msg_line=$(($linenum - 1))
if sed "$msg_line!d" $filename | grep 'PANIC SAFETY' > /dev/null ; then
crate_panics=$(($crate_panics + 1))
else
echo "Unchecked panic at $filename:$linenum"
crate_panics=$(($crate_panics + 1))
failed=1
fi
done < <(grep -n -r "allow(clippy::$panic_marker)" ./"$crate" | awk -F ':' '{ print $1 " " $2 }')
done
echo "$crate: $crate_panics"
total_panics=$(($total_panics + $crate_panics))
done
echo "Total Panics: $total_panics"
if ((failed > 0))
then
exit $failed
else
# Check for "should_panic"s without "expected = ..."
num_should_panic=$(grep -inr --include \*.rs should_panic | wc -l)
echo "num 'should_panic's " $num_should_panic
num_should_panic_lparen=$(grep -inr --include \*.rs should_panic\( | wc -l)
echo "num 'should_panic('s " $num_should_panic_lparen
if ((num_should_panic == num_should_panic_lparen))
then
exit 0
else
echo "failed should_panic( test"
echo "every 'should_panic' should also be a 'should_panic('"
exit 1
fi
fi