Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the Auth section of the README about? #93

Open
DivineDominion opened this issue Nov 22, 2021 · 6 comments
Open

What's the Auth section of the README about? #93

DivineDominion opened this issue Nov 22, 2021 · 6 comments

Comments

@DivineDominion
Copy link

It's about this part:

Add a line to your auth source files with your login and token: [...]

Bluntly, I just don't know what "my auth source files" refers to in this context :)

@jacobpmeyer
Copy link

+1 to this.

@wandersoncferreira
Copy link
Collaborator

I have a conflict of interest now as I am contributing to this package but also developing a new version of this same package https://github.com/wandersoncferreira/code-review which should have this same issue. I added the usual path to the authinfo file here https://github.com/wandersoncferreira/code-review#auth-1

could you try and see if this is enough documentation to make the package work? (either GitHub-review or code-review)

@DivineDominion
Copy link
Author

In the meantime, I got lucky and was tutored excellently by @ilemming on twitter:
https://twitter.com/iLemming/status/1463599279457673220

A segue about the file might indeed be useful in the README.

@wandersoncferreira Your example should be enough to get people going. I noticed the path is only mentioned for GitLab, not GitHub right above.

@wandersoncferreira
Copy link
Collaborator

Good point @DivineDominion . I will mention this tweet link too :)

@wandersoncferreira
Copy link
Collaborator

https://github.com/wandersoncferreira/code-review#setup let me know.

@DivineDominion
Copy link
Author

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants