New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing poster attribute from video element #1050

Open

lszabolcs opened this issue Apr 4, 2023 · 0 comments

lszabolcs commented Apr 4, 2023

Describe the bug
Plyr doesn't render a valid poster attribute to the video element, just a data-poster.

To Reproduce
Steps to reproduce the behavior:

Place a video on a page using usePlyr, with poster option.
Check the inspector

Example: https://codesandbox.io/s/peaceful-carlos-oy7p26?file=/src/Plyr.jsx

Expected behavior
Render a video element with valid poster attribute.

Screenshots

Desktop (please complete the following information):

OS: macOS 13.2
Browser: Firefox
Version: 111.0.1

Additional context
I understand that Plyr uses data-poster to create a poster element, and visually it works. But it's bad for SEO.
https://developers.google.com/search/docs/appearance/video#video-thumbnail

I also tried to add the poster attribute directly to the video element, but it didn't worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment