Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Whammy #81

Closed
chrahunt opened this issue Oct 22, 2016 · 1 comment
Closed

Fix Whammy #81

chrahunt opened this issue Oct 22, 2016 · 1 comment
Labels
bug

Comments

@chrahunt
Copy link
Owner

Whammy mis-parses the WebP frames and that causes problems due to incorrect width and a validation that's applied later on. See here.
@chrahunt chrahunt added bug 1.x and removed 2.x labels Oct 22, 2016
@chrahunt chrahunt added this to the 1.3.1 milestone Oct 25, 2016
@chrahunt chrahunt removed this from the 1.3.1 milestone Nov 17, 2016
@chrahunt
Copy link
Owner Author

chrahunt commented Nov 21, 2016 •
edited
Loading

As mentioned here, there is a possible solution in antimatter15/whammy#47. This makes sense because Whammy is mistaking the bytes of an ALPH chunk (which holds transparency information) for the start code of a VP8 chunk. If the Canvas-to-webp serialization code omits any such chunks when there's no transparency then the above should work.

chrahunt added a commit that referenced this issue Nov 22, 2016
@chrahunt
Merge pull request #103 from chrahunt/fix-whammy
0998157 
Workaround for Whammy parsing issue. Fixes #81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrahunt