Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-collection w/ one feature #4

Open
jessekrubin opened this issue Nov 21, 2024 · 5 comments
Open

feature-collection w/ one feature #4

jessekrubin opened this issue Nov 21, 2024 · 5 comments

Comments

@jessekrubin
Copy link

why is examples/problematic_geometries/problematic_multitype_geometry_with_just_one_geometry.geojson problematic?

The geojson spec says a feature collection can have 0+ features

@chrieke
Copy link
Owner

chrieke commented Nov 21, 2024

Hey, yes you are correct. It's not invalid (not in the invalid category), but listed here as a "problematic" example (problematic category). As a reminder that this case should be handled in your code/tool, which some don't and sometimes fail when feeding in this type.

@jessekrubin
Copy link
Author

@chrieke thanks for your reply!

I found 2 more problems.

  • examples/invalid_structure/invalid_geometry_geometrycollection_nested.geojson is totally valid -- you can have nested geometry collections
  • examples/invalid_structure/invalid_geometry_geometrycollection_single.geojson is also valid -- you can have just one geometry w/ in a geom-collection

@jessekrubin
Copy link
Author

jessekrubin commented Nov 21, 2024

structurally invalid

  • examples/invalid_geometries/invalid_less_three_unique_nodes.geojson should be moved to invalid-structure as it is structurally invalid -- polygon needs at least 4 points regardless of uniqueness
  • examples/invalid_geometries/invalid_incorrect_geometry_data_type.geojson should also be moved invalid-structural -- structure is invalid for line string

mixed feelings

  • examples/problematic_structure/invalid_crs_defined.geojson I have mixed feelings on crs in geojson as it is technically deprecated, however it is extremely useful when working with other crs-s (no idea how to pluralize that)

@chrieke
Copy link
Owner

chrieke commented Nov 21, 2024

Thanks for checking it out and the comments and suggestions! Will have a look on the weekend and get back!

@jessekrubin
Copy link
Author

@chrieke no problemo! lmk if there is anything I can do to help! thanks for putting this repo together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants