Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof WAITLIST #651

Open
wopian opened this issue Feb 20, 2020 · 11 comments · May be fixed by #795
Open

Proof WAITLIST #651

wopian opened this issue Feb 20, 2020 · 11 comments · May be fixed by #795
Assignees
Labels
Size: Moderate 500 to 749 lines
Milestone

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020

Proof read transcribed code of WAITLIST against scans

Lines: 564
Page: 1117—1132 (15)

Reduced quality scans can be found here

@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@cetfor
Copy link

cetfor commented Feb 26, 2020

Minor issues:

Page 1122, BZMF WAITP00H should be BZMF WAITPOOH Note the 0 vs O. (link)

The label is on page 1132 where WAITP00H DXCH WAITEXIT should be WAITPOOH DXCH WAITEXIT (link)

These seem to be corroborated by this source.

In the images compare the "WAITPOOH" to the O in "OVERFLOW HAS OCCURRED".

@cetfor
Copy link

cetfor commented Feb 26, 2020

A similar issue occurs on page 1131 where both LONGP00H should be LONGPOOH (link).

The corresponding label is on page 1132 (link).

Page 1132, WAITP00H should be WAITPOOH (link)

Page 1132, P00DOO1 should be POODOO1 (link) - the corresponging label is on page 1384 (img link, code link). Note the use of the label is in the correct form (POODOO1).

These are the only issues I was able to find. I thought a discussion would be better than jumping into a PR - but please let me know if you agree and would like a PR.

Thanks!

@wopian
Copy link
Collaborator Author

wopian commented Feb 26, 2020

Please do not use the HTML source code provided by Ibiblio - those files and this repo come from the same 2009 digitisation source. The images provided by Ibiblio are the only true source 👍

PRs are always welcome :)

@zpeters
Copy link
Contributor

zpeters commented Oct 6, 2020

Shall i pick this up and create a PR for the changes?

@wopian
Copy link
Collaborator Author

wopian commented Oct 7, 2020

@zpeters go ahead!

@r-sreesaran
Copy link

@zpeters are you still working on this issue ?. Can i pick this up ?

@zpeters
Copy link
Contributor

zpeters commented Oct 27, 2020

I have fallen behind lately. Please go ahead and pick this up

@r-sreesaran
Copy link

I am working on this issue.

@r-sreesaran
Copy link

r-sreesaran commented Oct 27, 2020

Few observations here.
In line Link Just after the text ASSEMBLY (Line R0005) there are two -- which is not present in the original image Image

Like wise in page 1117 in the image there is only a single hyphen, but in case of code in github there are two hyphen present is this okay.

In Page 1118 in the line R069 there is hyphen present Image correspondingly the same is missing in
(Link)(https://github.com/chrislgarry/Apollo-11/blob/master/Luminary099/WAITLIST.agc#L110)

In page 1121 line 0124 Image I am not sure if its PRI035 or PR1035 . In the code it is displayed as PRI035 (Link)(https://github.com/chrislgarry/Apollo-11/blob/master/Luminary099/WAITLIST.agc#L187)

@r-sreesaran
Copy link

@wopian Any comments here ?.

@wopian wopian assigned r-sreesaran and unassigned zpeters Oct 28, 2020
@wopian
Copy link
Collaborator Author

wopian commented Oct 28, 2020

@r-sreesaran: Like wise in page 1117 in the image there is only a single hyphen, but in case of code in github there are two hyphen present is this okay.

These should be replaced by a single hyphen to match scans.

@r-sreesaran: In Page 1118 in the line R069 there is hyphen present Image correspondingly the same is missing in Link

The hyphen from scans should be added

@r-sreesaran: In page 1121 line 0124 Image I am not sure if its PRI035 or PR1035 . In the code it is displayed as PRI035

This occurs in other places with clearer scans which show its most likely PRIO35 (letter i, letter o) than PR1035 - in 1098 the I is printed clearly and the letter O is more square than the nearby zeroes (identical to the o in OCT)

@wopian wopian linked a pull request Oct 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: Moderate 500 to 749 lines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants