Balancer Status missing one Byte

[gallersd]

BalancingOne consists of only 30 characters where it should be 32.

I assume line
towerAttributes[towerNumber].balacing = data.slice(17,32).toString("hex");
must be changed to
towerAttributes[towerNumber].balacing = data.slice(17,33).toString("hex");

[gallersd]

... of course same for tower 2:

towerAttributes[towerNumber].balacing_two = data.slice(17,32).toString("hex");

change to

towerAttributes[towerNumber].balacing_two = data.slice(17,33).toString("hex");

[christianh17]

should be solved in github, can you please check?

[gallersd]

I installed via IObroker from GitHub but version number did not change.
Shall I try in another way ?

Further problem is that I seldomly see balancing - but will report ASAP ...

[christianh17]

I did not change the version number, just changed the code. This should work as long as you install via URL.

[gallersd]

My Balancer started today and for me the bug is fixed.
The additional BitCount value is great and my calculation results in the same value.
So I do not need my own calc anymore :-)

I only see a minor issue with the Object Name "tower state" to be identical for
BalancingCountOne
BalancingCountTwo
BalancingOne
BalancingTwo

[christianh17]

Thanks for the feedback :-) Till now the states are only used in very few installations, so I could change it easily without thinking about a migration strategy. Do you have a suggestion for the name and structure of the states? I thought about one value per module but didn't have a good idea how to name the states.
Any suggestions are welcome!

[gallersd]

BalancingBitCountOne
BalancingBitCountTwo
BalancingStateOne
BalancingStateTwo

[zloe]

Wouldn't "BalancingCellCountXXX" be a more appropriate name?
It is the number of Cells that are being balanced, right?

[christianh17]

siehe andere Kommentare