-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a more fully-featured print... #17
Comments
Sorry, forgot to mention that the above code doesn't use '#display' directly, but uses self.config.selectDisplay (which is "#display" for xkcd). My local copy of cli.js uses
... though they should arguably be structured like:
|
Nice! One question though... why are you storing the helper functions in arguments.callee instead of using closures? I also like the move to parameterized element selectors, though I think we could make the names shorter by making them named like "config.el.screen"... Could you please start pushing your local changes to a repository? That would make it a lot easier to merge them in. |
i stuff then in callee because it saves memory, rather than re-creating the functions for each instance. i've refactored my local copy to use config.select.screen (etc), by the way. i'll be happy to push, but i am a complete git newbie (i'm used to cvs/svn/fossil). i'm afraid that some of my current changes might break your code, so i will send it to you for approval/test before i commit. (Or how can i start a branch?) |
In git, each user can have their own independent repository, so you can push and maintain your own version of the tree. I can then pick and choose pieces to merge in to mine. It's really easy to set one up -- just head over to http://github.com/repositories/new and follow the instructions. |
okay, i've set up http://github.com/sgbeal/xkcdfools. i'll get my changes into there and let you know. |
Great! I'll be watching for it. |
Here's a variation of Terminal.print which accepts arrays of arguments, and each argument may be a jQuery element, a function (it is run to get its contents), or "anything else" (anything handled by jQuery.append()).
This could certainly be improved upon, but this seems to work okay...
The text was updated successfully, but these errors were encountered: