Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fivem crash windows sourcegraph link invalid #2735

Open
Mathu-lmn opened this issue Aug 20, 2024 · 1 comment · May be fixed by #3036
Open

Fivem crash windows sourcegraph link invalid #2735

Mathu-lmn opened this issue Aug 20, 2024 · 1 comment · May be fixed by #3036
Labels
bug triage Needs a preliminary assessment to determine the urgency and required action

Comments

@Mathu-lmn
Copy link
Contributor

What happened?

When crashing, we sometimes get the sourcegraph link to the fivem's code source. However this link comes invalid (code :

fivem/code/client/launcher/Minidump.Symbolication.cpp

Line 76 in fbef73f

lineDetail = fmt::sprintf(" (<A HREF=\"https://sourcegraph.com/github.com/citizenfx/fivem/-/blob/%s?L%d\">%s:%d</A>)",
)

Example output by the crash window : https://sourcegraph.com/github.com/citizenfx/fivem/-/blob/master/fivem/code/components/extra-natives-five/src/WeatherNatives.cpp?L58=
Working url : https://sourcegraph.com/github.com/citizenfx/fivem@master/-/blob/code/components/extra-natives-five/src/WeatherNatives.cpp?L58=

Expected result

A working url

Reproduction steps

  1. Crash
  2. Click the "blue" hyperlink
  3. See that the link is invalid

Importancy

Unknown

Area(s)

FiveM

Specific version(s)

Latest artifacts - Latest client

Additional information

No response
@Mathu-lmn Mathu-lmn added bug triage Needs a preliminary assessment to determine the urgency and required action labels Aug 20, 2024
@KillStr3aK
Copy link

this should get more attention as its annoying but such an easy fix

@Mathu-lmn Mathu-lmn linked a pull request Dec 24, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(minidump): correct sourcegraph link Mathu-lmn/fivem
2 participants
@KillStr3aK @Mathu-lmn