Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make defaultPageJSON a class variable #206

Open
pihart opened this issue Jun 30, 2021 · 0 comments
Open

Make defaultPageJSON a class variable #206

pihart opened this issue Jun 30, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
next

Comments

@pihart
Copy link
Collaborator

pihart commented Jun 30, 2021

It's currently a file-scoped [const] variable, which means that the client-side developer API can't edit its value.

It does not necessarily need to be a class variable of Pages, but it looks like this makes the most sense. (It also does not need to be static; it can be an instance variable of Pages or Page, but this seems wrong.)
@pihart pihart added the enhancement New feature or request label Jun 30, 2021
@pihart pihart added this to the next milestone Jun 30, 2021
@pihart pihart mentioned this issue Jun 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@pihart