PROPOSAL: Use prettyunits::pretty_bytes to prettify logging for multipart suggestion in put_object
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkaye97
commented
May 9, 2022
| @@ -247,7 +248,7 @@ function( | |||
| } | |||
|
|
|||
| if (!is.na(size) && size > partsize) | |||
| message("File size is ", size, ", consider setting using multipart=TRUE") | |||
| message("File size is ", pretty_bytes(size), ", consider setting using multipart=TRUE") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416
My editor stripped some whitespace -- it's really a one-line change + some docs. Review without whitespace
Please ensure the following before submitting a PR:
/Rnot/manand rundevtools::document()to update documentation/testsfor any new functionality or bug fixR CMD checkruns without error before submitting the PR