Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust One Tricks Algorithm #11

Open
cnguy opened this issue Mar 6, 2018 · 3 comments
Open

Adjust One Tricks Algorithm #11

cnguy opened this issue Mar 6, 2018 · 3 comments

Comments

@cnguy
Copy link
Owner

cnguy commented Mar 6, 2018

Adjust the algorithm to scan the last 10-20 games to see if they're mostly playing the "one trick" champion they're normally playing (which they play for around >= 65% of their total games)

if so, add them
else, they're moving on

@cnguy
Copy link
Owner Author

cnguy commented May 16, 2018

This would solve issues like this page breaking.

http://onetricks.net/champions/janna/history

This breaks because one of the one tricks have not played for a long time, and the 'algorithm' for match history picks up a match that doesn't have perks and so it breaks..

@cnguy
Copy link
Owner Author

cnguy commented May 27, 2018

this should be ez t o implement, lets goo.

let's get rid of useless data now

@cnguy
Copy link
Owner Author

cnguy commented Aug 8, 2018

faed1b4

This code (pre-comments, I commented it since there seemed to be bugs) in this commit was intended to solve this issue, but it seemed like it was not robust enough. This issue is a 'idk' and will probably depend on more research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant