Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #127

Open
howlbot-integration bot opened this issue Oct 28, 2024 · 2 comments
Open

QA Report #127

howlbot-integration bot opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working grade-b Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sufficient quality report This report is of sufficient quality

Comments

@howlbot-integration
Copy link

howlbot-integration bot commented Oct 28, 2024

See the markdown file with the details of this report here.

@howlbot-integration howlbot-integration bot added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality labels Oct 28, 2024
howlbot-integration bot added a commit that referenced this issue Oct 28, 2024
howlbot-integration bot added a commit that referenced this issue Oct 28, 2024
@enitrat
Copy link

enitrat commented Nov 2, 2024

QA-01 → ❌ pc is incremented in the end label

QA-02 → ✅ address aliasing

QA-03 → ✅ lack of cancellation messaging

QA-04 EIP-2930 Transaction Decoding Failure → ❌ no POC no explanation, unsigned TX without signature

QA-05 → ❌ though it should be used with b - a by convention

QA-06 → ❌ Not valid EIP, still in draft and not applied

QA-07 → ✅ Incorrect Handling of 0^0 in Power Function

QA-08 → ❌  it will consume everything https://github.com/kkrt-labs/kakarot/blob/e3156b4c3d33d41cc309c6c67eadc370262a99b9/cairo_zero/kakarot/precompiles/precompiles.cairo#L261

QA-09 → ❌no POC no explanation

QA-10 → ❌  no poc no explaination

QA-11 → ❌ used from cairo0

QA-12 → ❌ report misunderstands selfdestruct

@ClementWalter ClementWalter added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 4, 2024
@c4-judge
Copy link
Contributor

c4-judge commented Nov 8, 2024

dmvt marked the issue as grade-b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-b Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

4 participants