Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client filtering of conversation part types for authorized users #1692

Open
daveconnis opened this issue Jan 15, 2018 · 0 comments
Open

Comments

@daveconnis
Copy link
Contributor

Problem

Add the ability for authorized users (admin) to filter by conversation part type.

This is currently blocked by 1638 and 1689.

Add client-filtering of parts based on authorizaton

Wrap non-comment parts in the conversation thread under a {{#if canAdminister project}} helper, to hide non-comment parts from users who aren't admins on project.

Add integration tests to support this change

Render a thread with one of each supported part type, register a fake project ability with canAdminister: true
Render a thread with one of each supported part type ,register a fake project ability with canAdminister: false, see if just the comment part is rendered
See tests/integration/components/task-assignment-test.js on how to register a fake ability

References #1636 #1638, #1689

Progress on: #1597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant