Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari extension support #22

Open
mwarkentin opened this issue May 26, 2023 · 3 comments
Open

Safari extension support #22

mwarkentin opened this issue May 26, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mwarkentin
Copy link

mwarkentin commented May 26, 2023

It would be great to support this extension in Safari!

Apple has some docs about converting an existing web extension for use in Safari so maybe this wouldn't be too much work. :)

Image

@eliatcodecov
Copy link
Contributor

Thanks for posting! I can't give a definitive time frame on this, but we'll take a look and see how much work would go into this. If it's straightforward, we can try to slot it in.

@eliatcodecov eliatcodecov added the enhancement New feature or request label May 31, 2023
@spalmurray-codecov
Copy link
Collaborator

Using the linked conversion program apple provides, the extension Immediately works for file coverage, as pictured. PR coverage does not work, couldn't easily find the bug and don't want to continue spending time on this until we decide we want to move forward with this. I can't see any reason why it wouldn't work though, once that bug is squashed. There also seems to be some investigation and work to do around adapting the extension for safari and integrating the safari build into our CD pipeline. All of that being said, at first glance it seems like this should be a relatively painless conversion.

Image

@spalmurray-codecov
Copy link
Collaborator

Upon further investigation into the bug, it seems Safari handles cookie access differently to chrome and ff. I could not find a workaround using Safari APIs, but if we add support for using a Codecov API key for cloud Codecov, the Safari conversion should work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants