Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image previews of JPEG files in insecure http mode #7082

Open
jmikedupont2 opened this issue Nov 19, 2024 · 2 comments
Open
Labels
enhancement Some improvement that isn't a feature

Comments

@jmikedupont2
Copy link

What is your suggestion?

Add support for image previews of JPEG files when served via the VS Code web server, allowing users to view image content directly in the browser without needing to download or open the files separately.


Why do you want this feature?

This feature would improve user experience by enabling quick visualization of image assets directly in the web server interface, which is particularly useful for web developers, designers, and anyone working with visual media. It would save time and streamline workflows, especially when dealing with multiple images.


Are there any workarounds to get this functionality today?

Currently, users can manually open JPEG files in a browser tab or use third-party tools to preview images. However, these workarounds disrupt the development workflow and are less efficient compared to having built-in preview support.


Are you interested in submitting a PR for this?

Potentially, yes, it would be a great learning experience
Image

@jmikedupont2 jmikedupont2 added the enhancement Some improvement that isn't a feature label Nov 19, 2024
@code-asher
Copy link
Member

This does actually work, but I think it might require a secure context because it relies on some browser features only available in secure contexts. Are you able to use https or add an exception for http://192.168.1.90:8080 in your browser?

@jmikedupont2
Copy link
Author

i guess i can do that with a self signed https, will try, but not the best user experience for n00bs

@jmikedupont2 jmikedupont2 changed the title Add support for image previews of JPEG files Add support for image previews of JPEG files in insecure http mode Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

2 participants