Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text -> sign using transformer decoder #225

Merged
merged 2 commits into from
Oct 2, 2020
Merged

text -> sign using transformer decoder #225

merged 2 commits into from
Oct 2, 2020

Conversation

gittygupta
Copy link
Contributor

@gittygupta gittygupta commented Oct 2, 2020 •
edited
Loading

Description

Contributed a sign language production architecture that converts text to german sign language using rwth-phoenix-2014t dataset, to NLP folder under Machine Learning

Make sure you have:

  • Visited http://join.codezoned.com/
  • Starred ScriptsDump!
  • Referred the issue number in the fixes title below.
  • Made a PR in Join_codezoned.
  • Joined our discord server.

Fixes #224

Added a folder containing all the scripts

Please delete options that are not relevant.

  • New Script
  • New Category (Is any new category being made to accommodate this script)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@gittygupta gittygupta closed this Oct 2, 2020
@gittygupta gittygupta reopened this Oct 2, 2020
master-fury
master-fury requested changes Oct 2, 2020
View reviewed changes
Copy link
Member

@master-fury master-fury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Can you please write a proper readme for the users so that your code can be used by people also it will help people understand the concept better? Also select the things you did while raising the PR (follow the template) like star, new script etc.

@gittygupta
Copy link
Contributor Author

gittygupta commented Oct 2, 2020 •
edited
Loading

Nice work! Can you please write a proper readme for the users so that your code can be used by people also it will help people understand the concept better? Also select the things you did while raising the PR (follow the template) like star, new script etc.

Yes I just ticked those options, and would it help if I uploaded a pdf of the mathematics behind this whole thing? Because writing a whole markdown file will be a bit time consuming, but I have a whole proposal written for it.

@gittygupta
Copy link
Contributor Author

Nice work! Can you please write a proper readme for the users so that your code can be used by people also it will help people understand the concept better? Also select the things you did while raising the PR (follow the template) like star, new script etc.

Yes I just ticked those options, and would it help if I uploaded a pdf of the mathematics behind this whole thing? Because writing a whole markdown file will be a bit time consuming, but I have a whole proposal written for it.

Though I have added the pdf, please let me know if a markdown readme file would be so necessary. I will surely do it. Also, the pdf will definitely help the readers. Please do consider merging if you feel it is contributory. Thank you!

@master-fury
Copy link
Member

Nice work! Can you please write a proper readme for the users so that your code can be used by people also it will help people understand the concept better? Also select the things you did while raising the PR (follow the template) like star, new script etc.

Yes I just ticked those options, and would it help if I uploaded a pdf of the mathematics behind this whole thing? Because writing a whole markdown file will be a bit time consuming, but I have a whole proposal written for it.

Sure, that will do it.

master-fury
master-fury approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@master-fury master-fury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@master-fury master-fury merged commit 03cfc77 into codezoned:master Oct 2, 2020
@gittygupta
Copy link
Contributor Author

Nice work!

Thank you! Its my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@master-fury master-fury master-fury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NLP scripts
2 participants
@gittygupta @master-fury