Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: getFrameMessage throws FetchError when message is not valid #236

Closed
cnasc opened this issue Mar 8, 2024 · 5 comments
Closed

Bug: getFrameMessage throws FetchError when message is not valid #236

cnasc opened this issue Mar 8, 2024 · 5 comments

Comments

@cnasc
Copy link
Contributor

cnasc commented Mar 8, 2024

Describe the bug and the steps to reproduce it

  1. Send unsigned message to frame (can do this with framegear, just don't have allowFramegear property set)
  2. See in console ⨯ FetchError: non-200 status returned from neynar : 400
  3. Cannot use isValid to send error state because of runtime error

What's the expected behavior?

This failure should be handled in getFrameMessage so that isValid is false when this occurs. That will allow us to send customized error states.

What version of the libraries are you using?

"@coinbase/onchainkit": "0.10.0"
@ktarun1419
Copy link

Hi @cnasc can i work on this issue ?

@cnasc
Copy link
Contributor Author

cnasc commented Mar 14, 2024

@ktarun1419 feel free!

@Zizzamia
Copy link
Contributor

@ktarun1419 Niiiiice!

@claudioantonio
Copy link

I think this issue relates to Zizzamia/a-frame-in-100-lines#17

@cpcramer
Copy link
Contributor

cpcramer commented Dec 5, 2024

Frames have been deprecated.

@cpcramer cpcramer closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Zizzamia @cnasc @claudioantonio @cpcramer @ktarun1419 and others