Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call failure when no video device available #12

Open
dudash opened this issue Feb 18, 2022 · 2 comments
Open

Call failure when no video device available #12

dudash opened this issue Feb 18, 2022 · 2 comments
Assignees
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed

Comments

@dudash
Copy link
Member

dudash commented Feb 18, 2022

Describe the bug
When making an outgoing call on linux (probably all platforms), if the clivrt cannot open the /dev/video0 then call won't be made.

To Reproduce
Steps to reproduce the behavior:

  1. open the app
  2. 'login' to the signaling server
  3. connect another user to the signaling server (using the test website)
  4. 'call' the other user from clivrt
  5. see error occurs in logs with unclear feedback to user (possibly putting us in a bad state?)

Expected behavior
Call is still placed with your video off -OR- an error message is displayed providing you more information and apologizing.

Additional context
This might be challenging to fix in the ideal way. I'd think being able to call someone with your video off should be possible. However, creating the video-offer cannot proceed without the device. It'd be nice to be able to request they call you, or to just join them and receive their video.

@dudash dudash added bug Something isn't working help wanted Extra attention is needed labels Feb 18, 2022
@andykrohg
Copy link
Collaborator

Video-offer doesn't necessarily need a device; all it needs is a track (video/audio). In the event that device access fails for some reason, we could use the aortic library to create a backup track (like send the red hat logo or something) and just send it at 30fps. See example here: https://github.com/aiortc/aiortc/blob/main/examples/videostream-cli/cli.py#L20

@andykrohg andykrohg self-assigned this Feb 18, 2022
@dudash
Copy link
Member Author

dudash commented Feb 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants