Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tuning (profiling?) #4

Open
dudash opened this issue Feb 2, 2022 · 3 comments
Open

Performance tuning (profiling?) #4

dudash opened this issue Feb 2, 2022 · 3 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@dudash
Copy link
Member

dudash commented Feb 2, 2022

I quickly tried to get cProfile going and also Austin with VSCode plugin

But no dice. Need to spend a little more time - the incoming video frame rendering isn't as good as we need it to be. There is likely optimization needed here:
https://github.com/collabinator/video-to-ascii/blob/master/video_to_ascii/render_strategy/ascii_strategy.py

@dudash
Copy link
Member Author

dudash commented Feb 2, 2022

@andykrohg if you're looking for something to tinker with...

@dudash
Copy link
Member Author

dudash commented Feb 2, 2022

from chat today: quick fix might be to drop frames of incoming video before processing through the ascii transformer. Will probably want the "how many" to be configurable via .clivrt config file

Seems like this should be a setting we can pass into aiortc

@dudash dudash added the enhancement New feature or request label Feb 2, 2022
@dudash dudash changed the title Performance tuning with profiling Performance tuning (profiling?) Feb 18, 2022
@dudash dudash added the help wanted Extra attention is needed label Feb 18, 2022
@dudash
Copy link
Member Author

dudash commented Oct 7, 2022

@andykrohg I tagged this and a few other issues with the hacktoberfest label, if you're interested in helping this month

https://hacktoberfest.com/participation/#contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant