Pull Request Test Coverage Report for Build 11329186809

Details

• 20 of 38 (52.63%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 96.882%

Totals
Change from base Build 11317448813:	-0.5%
Covered Lines:	3520
Relevant Lines:	3630

💛 - Coveralls

Hi, thanks for submitting this. Please add the test fixture param so that all tests also run with this timezone provider. I will hesitate to ship untested code and claim that it would work.

• parametrize tests
  

  icalendar/src/icalendar/tests/conftest.py

  Line 235 in 8cd6823

  def pytest_generate_tests(metafunc):

• add documentation on how to switch to dateutil
• add tests to make sure edge cases are considered (I do not know which ones these are)

We are currently working on it. Will do that!

Have fun! I will be back tomorrow possibly :)

If you need any help or you would like a review, please do not hesitate to notify us here. Thanks for the work!

@mtrd3v The code looks good. To integrate it, a few more changes are needed in other files. Would you like me to point them out?