-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live editing broken in docs #429
Comments
Weird—for some reason I can edit them just fine in Firefox, but it doesn't work in Chrome |
After checking again, it looks like it actually seemingly randomly goes back and forth between working and not working after refreshes (on Firefox). |
I don't know their document system well enough to debug. If it had been a clear issue originating from the color library, I would have spent more time looking at it. I saw some cross origin complaints and a shadow root complaint:
|
The issue seems to be the CORS error. Running chrome as below fixed the issue.
Safari did not seem to have an issue, and I was able to reproduce the intermittent issue with Firefox. I assume fixing the cores issue with Prism will likely get things working everywhere. |
I recently switched Prism Live to use ESM and I think that's what broke this. Should be an easy fix. |
Ok, that explains it. I was trying to figure out what changed. |
Should be fixed now, sorry about that! |
@LeaVerou It is working again! As a side note, I'm not sure if you are aware, but selections are invisible currently, it makes it difficult to select and copy specific things in examples. I assume it is a style regression, but I haven't looked into it too much yet. |
Oof, no, I was not aware, thanks. Will fix it today. |
FYI, the selection issue seems to be chrome only. |
It is only mac as well... |
The live editor is still (again?) broken for me in Chrome:
|
Yes, I noticed this as well. Had not gotten around to commenting. |
Ugh, sorry about that. I’ll take a look. FWIW that should not hold up the release. |
As title mentions, none of the live examples allow editing.
The text was updated successfully, but these errors were encountered: