Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Status message doesn't get through when shutting down #16

Open
burdoto opened this issue Aug 14, 2023 · 0 comments
Open

Offline Status message doesn't get through when shutting down #16

burdoto opened this issue Aug 14, 2023 · 0 comments
Labels
bug Something isn't working prio:medium Issue has medium priority

Comments

@burdoto
Copy link
Member

burdoto commented Aug 14, 2023

This is due to the bot requesting the last bot message every time it tries to post an update rather than keeping the most recent ID, which is too slow on shutdown.

Also, Offline messages should use a fast resolving;

  • if there is no recent message ID, just send a new one
  • if there is, just send the edit and call it a day
    Maybe it's not necessary to make this check after housekeeping the ID properly.
@burdoto burdoto added bug Something isn't working prio:medium Issue has medium priority labels Aug 14, 2023
burdoto added a commit that referenced this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:medium Issue has medium priority
Projects
None yet
Development

No branches or pull requests

1 participant