Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importing things that aren't needed in components #303

Open
KorvinSzanto opened this issue Jul 31, 2023 · 2 comments
Open

Avoid importing things that aren't needed in components #303

KorvinSzanto opened this issue Jul 31, 2023 · 2 comments

Comments

@KorvinSzanto
Copy link
Member

By importing Vue in components like we do for Icon we're making it so that any bundle that includes this component must also include all of Vue. It's important to keep components as minimal as possible so that we don't end up including vue over and over.

@aembler
Copy link
Member

aembler commented Jul 31, 2023

Hah yeah we should strip that out

@KorvinSzanto
Copy link
Member Author

I'm not really sure what the best way is to include that config bit, it seems like import {config} from 'vue' works but it still seems excessive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants