Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recipe in general #69

Open
hmaarrfk opened this issue Sep 15, 2024 · 0 comments
Open

Improve recipe in general #69

hmaarrfk opened this issue Sep 15, 2024 · 0 comments
Labels
question Further information is requested

Comments

@hmaarrfk
Copy link

Comment:

There are a few curious things I noticed when I was studying the caiman recipe: conda-forge/conda-forge-ci-setup-feedstock#339

  1. caiman v1.11.3 #66 the latest PR failed the windows builds, and you were OK merging this. this means that your users don't have the latest windows build regardless of this PR.
  2. I think you can patch out the hard requirement on tensorflow.
  3. The numpy pinning is not correct. I've tried to fix this in the PR below. Lets discuss there
  4. Your activate/deactivate scripts are very opinionated. These generally don't have a place in the environment global configuration for a library package such as Caiman. Generally, these would be defined more programatically within your analysis tool's startup function.

Some tips:

  1. Work to remove "convenience" dependencies from the recipe (such as jupyter and bokeh)
  2. Move bokeh and holoviews to lazy imports.
  3. Remove the dependency on jupyter
  4. nose is deprecated and no longer maintained, get rid of it. pytest is nearly a drop in dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant