Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #178.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #178

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

conda-forge-webservices[bot] and others added 2 commits September 10, 2024 13:50
@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

@ReimarBauer
Copy link
Contributor

ReimarBauer commented Sep 10, 2024

@h-vetinari

Thanks for fixing this. Do we need to set a different build number?
Or don't we need to update the existing package, because it was only in the description but can't be used.

I am not sure if a merge will copy over or just drop.

@h-vetinari
Copy link
Member

h-vetinari commented Sep 10, 2024

This was mostly me testing whether the build still passes if we remove the default channels. We don't have to merge this PR, though if you'd like to we can (and then it's safer to bump the build number indeed). Otherwise you can just pick up 56dde22 whenever you do the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants