Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipes for neuraloperators and configmypy #28667

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

sarthakpati
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 20, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/configmypy/meta.yaml, recipes/neuraloperator/meta.yaml) and found some lint.

Here's what I've got...

For recipes/configmypy/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package configmypy using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

For recipes/neuraloperator/meta.yaml:

  • ❌ The home item is expected in the about section.

For recipes/neuraloperator/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12432957112. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/configmypy/meta.yaml, recipes/neuraloperator/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/configmypy/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package configmypy using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12433100394. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 20, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraloperator/meta.yaml, recipes/configmypy/meta.yaml) and found it was in an excellent condition.

@sarthakpati
Copy link
Contributor Author

Error is coming from the fact that one of the dependencies does not have the latest version on conda, yet.

This PR fixes it: conda-forge/torch-harmonics-feedstock#8

@sarthakpati
Copy link
Contributor Author

@conda-forge/help-python please review

@sarthakpati
Copy link
Contributor Author

@ocefpaf the recipe is not building without the python_min line.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 23, 2024

@ocefpaf the recipe is not building without the python_min line.

It should. Let's see the logs. Please make the change.

@sarthakpati
Copy link
Contributor Author

So weird. Anyway, this should be good to go (the Windows builds are failing because of torch, which should be fine once the actual recipe goes through). Thanks, @ocefpaf

Comment on lines 37 to 38
# imports:
# - neuralop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you are not doing the import test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the import test was not working correctly (see 61114c5), hence I have left it commented. I will discuss this with the package authors and suggest a couple of changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plaease re-add it here so we can see the logs and how it fails.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12467797927. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraloperator/meta.yaml, recipes/configmypy/meta.yaml) and found it was in an excellent condition.

@sarthakpati
Copy link
Contributor Author

@ocefpaf I believe the logs are pointing to a need to have the python_min defined [ref]:

jinja2.exceptions.UndefinedError: 'python_min' is undefined

@ocefpaf
Copy link
Member

ocefpaf commented Dec 23, 2024

@beckermr do you have any idea what is going on here? Or are we supposed to define the python_min again?

@beckermr
Copy link
Member

Try opening two separate PRs, one for each recipe. If you examine the logs carefully, there is an error where staged-recipes tries to build configmypy second, not first as it should. I think this is the actual error and the python_min stuff is a red herring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants