Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize repository structure with other connect js packages #490

Merged
merged 15 commits into from
Dec 4, 2024

Conversation

paul-sachs
Copy link
Collaborator

@paul-sachs paul-sachs commented Dec 3, 2024

Matching repository structure and scripts with connect-es.

  • Moved to npm
  • Use matching release process
  • Matched script names and functionality

To highlight some of the biggest changes:

  • Moved example into packages
  • Updated eslint config to more closely match connect-es
  • Match typescript config a little closer

Note: I was unable to maintain the pnpm lock file and convert it's contents to package-lock.json so all dependencies within allowed ranges have been updated.

Remaining tasks

  • Validate packed packages only contain what we need them to

@paul-sachs paul-sachs changed the title Standardized repository structure with other connect js packages Standardize repository structure with other connect js packages Dec 3, 2024
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
@paul-sachs paul-sachs marked this pull request as draft December 3, 2024 15:09
@paul-sachs
Copy link
Collaborator Author

The tsconfigs vary a bit, due to the fact that we have a root vite.config.ts. We currently won't check the validity of that in build because it would alter the structure of the output.

Signed-off-by: Paul Sachs <[email protected]>
@paul-sachs paul-sachs marked this pull request as ready for review December 3, 2024 16:07
turbo.json Outdated Show resolved Hide resolved
tsconfig.base.json Outdated Show resolved Hide resolved
packages/test-utils/package.json Outdated Show resolved Hide resolved
packages/connect-query/package.json Outdated Show resolved Hide resolved
packages/connect-query-core/package.json Outdated Show resolved Hide resolved
packages/connect-query-core/tsconfig.cjs.json Outdated Show resolved Hide resolved
paul-sachs and others added 7 commits December 4, 2024 10:08
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
@paul-sachs paul-sachs force-pushed the psachs/update-tooling-to-match branch from b073669 to 30ae0aa Compare December 4, 2024 15:08
@paul-sachs paul-sachs requested a review from timostamm December 4, 2024 15:26
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just left two small comments.

packages/connect-query-core/package.json Outdated Show resolved Hide resolved
packages/connect-query/package.json Outdated Show resolved Hide resolved
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@paul-sachs paul-sachs merged commit 07d105b into main Dec 4, 2024
13 checks passed
@paul-sachs paul-sachs deleted the psachs/update-tooling-to-match branch December 4, 2024 20:42
This was referenced Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants