Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Use Option<TCid> for previous checkpoint in CheckData #77

Open
adlrocha opened this issue Mar 27, 2023 · 0 comments
Open

Use Option<TCid> for previous checkpoint in CheckData #77

adlrocha opened this issue Mar 27, 2023 · 0 comments
Assignees
Labels

Comments

@adlrocha
Copy link
Contributor

adlrocha commented Mar 27, 2023

In #79 we had to introduce the use of a genesis cid for the first checkpoint committed to avoid creating a corrupted state in the VM.

A better fix would be to use an Option<TCid<TLink<Checkpoint>> for that field in Checkpoints. This would require a larger refactor, and as we are expecting the format of checkpoints to change when we introduce cross-net messages, it is better to defer the fix for then:

pub prev_check: TCid<TLink<Checkpoint>>,

@adlrocha adlrocha changed the title Use Option<Cid> for previous checkpoint in CheckData Use Option<TCid> for previous checkpoint in CheckData Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants