Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include list of public chats from search.jabber.network #1841

Closed
ericschdt opened this issue Jan 24, 2020 · 17 comments
Closed

Include list of public chats from search.jabber.network #1841

ericschdt opened this issue Jan 24, 2020 · 17 comments
Assignees
Labels
good first issue improvement MUC Related to multi-user chats (MUC) / group chats

Comments

@ericschdt
Copy link

ericschdt commented Jan 24, 2020

It's so comfortable to have a list of well known public MUCs like in Conversations to choose from, that I really miss having feature in Converse.js :)

You may also go to the website, but 1) you have to know about it, 2) it's still at least 5 clicks more. ;)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@PawBud
Copy link
Contributor

PawBud commented Apr 11, 2022

It's so comfortable to have a list of well known public MUCs like in Conversations to choose from, that I really miss having feature in Converse.js :)

You may also go to the website, but 1) you have to know about it, 2) it's still at least 5 clicks more. ;)

Can you post a screenshot if possible? I believe the app is only for android.

@deleolajide
Copy link
Member

This feature request has also been mention here

@PawBud
Copy link
Contributor

PawBud commented Apr 11, 2022

This feature request has also been mention here

Thanks for bringing it to my attention, I believe @Echolon can decide which issue to close

@Echolon
Copy link

Echolon commented Apr 11, 2022

@PawBud happy to support your preparations!

@PawBud
Copy link
Contributor

PawBud commented Apr 12, 2022

@PawBud happy to support your preparations!

Thanks, btw, I believe the HTTP API shall suffice, let me try to implement it.

@PawBud PawBud self-assigned this Apr 15, 2022
@PawBud
Copy link
Contributor

PawBud commented Apr 15, 2022

@Echolon
Screen Shot 2022-04-15 at 6 34 56 PM
I feel like its ok for the menu to be displayed when the show popular public groupchats button is clicked in the same muc-list dialog, also yeah ignore the styling for now

@jcbrand
Copy link
Member

jcbrand commented Apr 15, 2022

@PawBud: Thanks for looking into this. I think search.jabber.network should be used to provide autocomplete suggestions when you join a MUC via the add-chatroom modal, not via a button in the list-chatrooms modal that you show above.

Converse has a component converse-autocomplete that can be used to create inputs with auto-complete suggestions.

See here:

export default class AutoCompleteComponent extends CustomElement {

You pass it a getAutoCompleteList function which returns the autocomplete suggestions.

Here's an example of where the converse-autocomplete component is being used:

The goal for this ticket would be to replace the input in the add-modal template, with a converse-autocomplete component.

<input type="text" required="required" name="chatroom" class="form-control roomjid-input" placeholder="${o.chatroom_placeholder}"/>

@jcbrand
Copy link
Member

jcbrand commented Jun 2, 2022

@PawBud Can you please include a screenshot here of what the feature looks like?

@Echolon
Copy link

Echolon commented Jun 2, 2022

@jcbrand even this might be a different task: But showing a list of MUCs, maybe with its topic, might be a nice thing. Conversation does it, too.

@PawBud
Copy link
Contributor

PawBud commented Jun 2, 2022

@PawBud Can you please include a screenshot here of what the feature looks like?

Screen Shot 2022-06-02 at 3 27 20 PM

something like this?

@jcbrand
Copy link
Member

jcbrand commented Jun 2, 2022

Looks like the suggestions are cut off? Perhaps a CSS z-index bug?

@licaon-kter
Copy link
Contributor

So this has been implemented, right? 320f11f

Nice, but what I didn't see was a dialogue that informs me that

Channel discovery uses a third party service called search.jabber.network.

Using this feature will transmit your IP address and search terms to that service. See their Privacy Policy for more information.

...or something like that :)

@jcbrand
Copy link
Member

jcbrand commented Nov 3, 2022

Where would you expect to see that?

@jcbrand
Copy link
Member

jcbrand commented Nov 3, 2022

I guess it could go into the About modal for Converse.

@licaon-kter
Copy link
Contributor

Before accessing these external services, of course.

That text is from Conversations, which opens a dialogue that I can cancel if I don't agree.

I guess it could go into the About modal for Converse

So my only choice is either accept s.j.n terms or NOT use Converse? Rather limiting and odd...

@jcbrand
Copy link
Member

jcbrand commented Nov 3, 2022

The query to search.jabber.network is made via XMPP, not HTTP, so your IP address isn't leaked to it.

@licaon-kter
Copy link
Contributor

Oh, right, saw the console output but did not connect the dots. Then sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue improvement MUC Related to multi-user chats (MUC) / group chats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants