Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse haproxy unique_id #142

Open
asyd opened this issue Nov 25, 2024 · 5 comments
Open

Reuse haproxy unique_id #142

asyd opened this issue Nov 25, 2024 · 5 comments

Comments

@asyd
Copy link

asyd commented Nov 25, 2024

I want to reuse the request unique-id generated by haproxy, so I tried to add id=unique_id in haproxy SPOE configuration but I have:

DBG unknown kv entry name=id
@fionera
Copy link
Contributor

fionera commented Nov 25, 2024

This was removed with the rewrite to remove unwanted api surface. I am open to add this again but need some info's because i have to add some constraints to the id. how long are your id's?

@asyd
Copy link
Author

asyd commented Nov 25, 2024

Hi @fionera thanks for quick feedback! I use UUID so 36 bytes long

@nicolus
Copy link

nicolus commented Dec 20, 2024

I have the exact same use case with a 36 characters UUID. I generate an idea in the frontend and pass it on to everything else so that I can add them to error messages and investigate when a customer gets an error from the application, or in the case of coraza is blocked by a false positive.

This is a must have for me unless we can achieve the same result another way.

@asyd
Copy link
Author

asyd commented Dec 20, 2024

@nicolus mind to test my PR?

@fionera
Copy link
Contributor

fionera commented Dec 22, 2024

The issue i have with this is the cache we are using right now is broken anyway see #136 . I am working on a replacement but didn't had time yet to do that. Just supporting the id key inside the message is certainly a solution but I would either always use haproxy as generator for the id or never. Since we are apparently needing it, I would just replace the logic with the old one and use id() inside the haproxy config. What do y'all think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants