Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logging callback interface #28

Open
jptosso opened this issue Jun 28, 2023 · 0 comments
Open

Replace logging callback interface #28

jptosso opened this issue Jun 28, 2023 · 0 comments

Comments

@jptosso
Copy link
Member

jptosso commented Jun 28, 2023

Coraza and modsec logging works differently, which presents a challenge for libcoraza. In modsec, there logger callback per transaction, while in coraza there is a general error log callback.

  1. We need to set up a friendlier callback, modsec void is not properly documented, and it is weird.
  2. In the meantime we can use waf loggers instead transaction logger, but that will mean logs won't be aware of custom error logs in nginx for specific URLs or others, there will be only one error log per coraza context
  3. Make current log callback work for Coraza, it is just a placeholder, it is not working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant