Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break up inline elements (general plugin support) #134

Open
vic-t opened this issue May 2, 2021 · 1 comment
Open

Don't break up inline elements (general plugin support) #134

vic-t opened this issue May 2, 2021 · 1 comment

Comments

@vic-t
Copy link

vic-t commented May 2, 2021

It seems clear to me that it's not realistic that the prosemirror WYSIWYG editor will support all possible plugins. Maybe if you integrated it as a standard into DW and made it easy for other developers to plug into the concept, they would do the necessary work themselves (IMHO, a proper WYSIWYG editor that can further be extended by plugins would be a killer feature).

In the meantime, it would be much appreciated if the prosemirror plugin could be taught not to break up inline code tags from other plugins.

For example, I noticed that inline elements such as <plugintag>Sometext</plugintag> will always be broken down to 5 lines by the prosemirror plugin, 2 of them empty. Specifically, I tried this with the note plugin as well as the nodisp plugin. So, <note>Testnote</note> becomes

<note>

TestNote

</note>

It's certainly not a deal breaker because the plugin functionality is (usually) not affected by that. Still, the code gets blown up for no good reason and becomes harder to read.

If it's too much work to leave it as inline code, maybe you could get rid of the two empty lines at least?

@Monklite
Copy link

Monklite commented Aug 5, 2021

I have similar issues with the mdpage plugin. It keeps spacing out all my excerpts that are in markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants