Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve action link is shown to superuser #2, even though page is already approved by superuser #1 (while "number_of_approved" is set to 1) #156

Open
Chris75forumname opened this issue Jul 21, 2021 · 0 comments

Comments

@Chris75forumname
Copy link

Chris75forumname commented Jul 21, 2021

Hi,

While I am setting up, fixing up and testing the publish plugin for the use as an QM tool in our Intrawiki, I stumbled across another unexpected behaviour:

The "Approve action link" is shown to our second superuser (with approval rights), even though page has already been approved by other superuser (me) and while "number_of_approved" is set to just 1 in the admin section. This is confusing, since the banner is saying: "This is an approved version." while the link is saying: "Please approve this version." even though the 1 required approval has already been given.

Aim: I want that message disappear for the second superuser.

Did I miss anything? Maybe my setup of the "number_of_approved" which is set to just the number 1 is not working? Is there a special syntax or how can I fix this?

BTW, I think it should be called "number_of_approvals" instead.

And, BTW, "internal note" doesn't work either, in my setup. It is ignored, even though it is set, just like the "number of approved". Maybe these problems are related?

Thanks for your time!
Yours, Christian

@Chris75forumname Chris75forumname changed the title Approve message is shown to second superuser, even though page is already approved by other superuser (and while "number_of_approved" is set to 1) Approve message is shown to superuser #1, even though page is already approved by superuser #2 (while "number_of_approved" is set to 1) Jul 21, 2021
@Chris75forumname Chris75forumname changed the title Approve message is shown to superuser #1, even though page is already approved by superuser #2 (while "number_of_approved" is set to 1) Approve action link is shown to superuser #1, even though page is already approved by superuser #2 (while "number_of_approved" is set to 1) Jul 21, 2021
@Chris75forumname Chris75forumname changed the title Approve action link is shown to superuser #1, even though page is already approved by superuser #2 (while "number_of_approved" is set to 1) Approve action link is shown to superuser #2, even though page is already approved by superuser #1 (while "number_of_approved" is set to 1) Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant