CBL-5461 : Remove ios submodule from ios-ee repo #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velicuvlad
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
the env var PRODUCT is not needed anymore in this case, so it should be removed
We don't really need couchbase-lite-ios submodule inside couchbase-lite-ios-ee repo as in build we always checkout couchbase-lite-ios submodule to the top of the master or release branch. The reason that we have the submodule is to try to keep CE and EE repo in sync which turns out to be an unnecessary unproductivity task. We are now removing the ios submdoule from the ee repo now so that we don’t need to make them in-sync anymore. Plus : move download_vector_search_extension.sh script to ee repo. Plus : Minor fix to the encryption key property in CBLDatabaseConfiguration.m to add check readonly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need couchbase-lite-ios submodule inside couchbase-lite-ios-ee repo as in build we always checkout couchbase-lite-ios submodule to the top of the master or release branch.
The reason that we have the submodule is to try to keep CE and EE repo in sync which turns out to be an unnecessary unproductivity task. We are now removing the ios submdoule from the ee repo now so that we don’t need to make them in-sync anymore.
Plus : Move download_vector_search_extension.sh script to ee repo.
Plus : Minor fix to the encryption key property in CBLDatabaseConfiguration.m to add check readonly.
Note : Need to work on updating beryllium build manifest and script in jenkins's configuration before merge.