CBL-5434: Vector Index API Tests 21-26 [Obj-C] #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
approved these changes
Mar 5, 2024
| @@ -6,6 +6,7 @@ | |||
| // COUCHBASE CONFIDENTIAL -- part of Couchbase Lite Enterprise Edition | |||
| // | |||
|
|
|||
| #import "CBLErrors.h" | |||
There was a problem hiding this comment.
This is already included in CouchbaseLite.h which is included in the CBLTestCase.h so this is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the last spec, the whole obj-c vector index api test suite is now complete
16/26 are currently running, the rest being disabled and have their respective ticket at the start of the test (in a comment)
update TestVectorMatchOnNonExistingIndex off spec to check for consistency with fts
added 2 more index related tests to confirm behaviour - I think we can leave them here as they don't require the creation of a query such that to be moved under the query tests... and also not so many that we need to have a separate file for now