New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't Normal Blend mode reference both images? #122

Open

czerwinskilukasz1 opened this issue Apr 19, 2020 · 0 comments

czerwinskilukasz1 commented Apr 19, 2020

I noticed that Normal Mode in Blend process just copies the value from Image 1:

ImagePlay/IPL/src/processes/IPLBlendImages.cpp

Line 24 in 371bb20

#define ChannelBlend_Normal(B,L) (B)

Shouldn't it rather be: (A + B) / (FA + FB), where FA, FB are factors (weights) of the images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment