Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure cpus, memory, disk size and pull-secret file location when creating new cluster #215

Closed
dgolovin opened this issue May 14, 2024 · 2 comments

Comments

@dgolovin
Copy link
Contributor

Form to create OpenShift Local cluser is empty right now. Would be good to have:

  1. Makrdown property with short explanation where those configuration values coming from with link to open extension settings and external documentation
  2. Cpus, memory, disk size and optional pull-secret file location fields initialized by default from extension settings

image

Additional context

  -c, --cpus int                  Number of CPU cores to allocate to the instance (default 2)
  -d, --disk-size uint            Total size in GiB of the disk used by the instance (default 31)
  -m, --memory int                MiB of memory to allocate to the instance (default 4096)
  -p, --pull-secret-file string   File path of image pull secret (download from https://console.redhat.com/openshift/create/local)
@gbraad
Copy link
Contributor

gbraad commented May 29, 2024

Form to create OpenShift Local cluser is empty right now

As we prioritize crc config set (Configuration) over any other way to provide the settings. Providing them with the start command is a one-shot and not persisted for a recreation. We mostly noticed that people to use the same settings again and again.

So if you add a dialog, you would have to provide the defaults and/or the settings as configured. Defaults are enforced based on the preset... they are currently enforced in a single location (configuration dialog).

Take note, any parameter for crc start is not a guarantee to work from the extension, as the extension relies on the use of the API endpoint:

https://github.com/crc-org/crc/blob/813c80a473046247eb232bb7e9e3da79a954118b/pkg/crc/api/handlers.go#L119-L134

Note: I would not provide most of them besides those you mentioned, as NameServer is a special case, SharedDirs not actively advertised for Windows, etc.

@lstocchi
Copy link
Contributor

Closing. It was fixed by #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants