Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI handler testing #39

Closed
SaschaAdler opened this issue Feb 16, 2021 · 2 comments
Closed

CLI handler testing #39

SaschaAdler opened this issue Feb 16, 2021 · 2 comments
Assignees
@SaschaAdler
Labels
refactor No functionality change expected
Milestone
v2.0.0-beta

Comments

@SaschaAdler
Copy link

After a bunch of refactoring, the CLI handlers don't do too much. But they don't do nothing! I'm especially concerned for the inspect handler properly destroying the Container before it exits.
@SaschaAdler SaschaAdler added the refactor No functionality change expected label Feb 16, 2021
@SaschaAdler SaschaAdler added this to the v2 milestone Feb 16, 2021
@SaschaAdler SaschaAdler self-assigned this Feb 16, 2021
@SaschaAdler SaschaAdler modified the milestones: v2 (alpha), v2.0.0-beta Feb 19, 2021
@SaschaAdler
Copy link
Author

I've now been bitten by this twice. 🙃

@SaschaAdler SaschaAdler mentioned this issue Mar 31, 2021
Open
@SaschaAdler
Copy link
Author

Let's collect all test work in #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaAdler SaschaAdler

Labels
refactor No functionality change expected
Projects
None yet
Milestone
v2.0.0-beta
Development

No branches or pull requests
1 participant
@SaschaAdler